Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing to afg3000 driver #118

Merged
merged 2 commits into from
Feb 10, 2022
Merged

Conversation

jenshnielsen
Copy link
Collaborator

This would have caught the incorrect validator usage from #115

Also rewrite the driver to use the log attached to the instrument already

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2022

Codecov Report

Merging #118 (9cd0388) into master (0519fe3) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   19.85%   19.85%           
=======================================
  Files         121      121           
  Lines       14709    14708    -1     
=======================================
  Hits         2920     2920           
+ Misses      11789    11788    -1     
Impacted Files Coverage Δ
...codes_contrib_drivers/drivers/Tektronix/AFG3000.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0519fe3...9cd0388. Read the comment docs.

@jenshnielsen jenshnielsen merged commit f63bd4a into QCoDeS:master Feb 10, 2022
@jenshnielsen jenshnielsen deleted the afg3000_types branch February 10, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants