-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SignalCore driver #114
Conversation
That's interesting, mypy passed on my laptop: python -m mypy --ignore-missing-import --no-warn-unused-ignores -p qcodes_contrib_drivers
Success: no issues found in 156 source files |
likely because you have Windows? and the CI is using linux. mypy understands platform differences so we can fix it, let me find out how .... |
Well, I tried my best (can't make local test first) |
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
- Coverage 20.06% 19.82% -0.25%
==========================================
Files 120 121 +1
Lines 14568 14702 +134
==========================================
- Hits 2923 2914 -9
- Misses 11645 11788 +143
Continue to review full report at Codecov.
|
ok, I am out of ideas... |
Well, great thank for all that work! |
All in the title I guess ^^ .