Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smw driver #111

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Fix smw driver #111

merged 2 commits into from
Nov 23, 2021

Conversation

simonzihlmann
Copy link
Contributor

I found this driver not working by default. Here are the changes proposed to make it working.

@FarBo or @jenshnielsen could you please have a look at it? And maybe also @lankes-fzj. Thanks.

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2021

Codecov Report

Merging #111 (a4cf8c7) into master (8cc993a) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #111      +/-   ##
=========================================
- Coverage    6.99%   6.92%   -0.08%     
=========================================
  Files          97      97              
  Lines       12261   12261              
=========================================
- Hits          858     849       -9     
- Misses      11403   11412       +9     
Impacted Files Coverage Δ
...es_contrib_drivers/drivers/RohdeSchwarz/SMW200A.py 0.00% <0.00%> (ø)
qcodes_contrib_drivers/_version.py 43.36% <0.00%> (-3.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cc993a...a4cf8c7. Read the comment docs.

@jenshnielsen jenshnielsen merged commit 238f4f7 into QCoDeS:master Nov 23, 2021
@simonzihlmann simonzihlmann deleted the fix_SMW_driver branch January 11, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants