Validate numbers instead of ints

For reasons unclear to me, validation is performed before set_parsing, making the latter obsolete if validation for the set_parser type
QCoDeS · Oct 19, 2023 · d601bc2 · d601bc2
1 parent 79576e3
commit d601bc2
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/qcodes_contrib_drivers/drivers/Horiba/Horiba_FHR.py b/qcodes_contrib_drivers/drivers/Horiba/Horiba_FHR.py
@@ -165,7 +165,7 @@ def __init__(self, parent: InstrumentBase, name: str, cli, handle,
                            get_cmd=self._get_position,
                            set_cmd=self._set_position,
                            set_parser=int,
-                           vals=validators.Ints(min_value, max_value),
+                           vals=validators.Numbers(min_value, max_value),
                            unit=self.unit)
 
     @property
@@ -242,6 +242,7 @@ def __init__(self, parent: InstrumentBase, name: str, cli, handle,
         self.add_parameter('position',
                            label=f'{label} position',
                            get_cmd=False,
+                           set_parser=int,
                            set_cmd=self._set_position,
                            val_mapping=val_mapping)
 
@@ -264,7 +265,7 @@ def __init__(self, parent: InstrumentBase, name: str, cli, handle,
                            set_cmd=self._set_width,
                            set_parser=int,
                            unit=self.unit,
-                           vals=validators.Ints(min_value, max_value),
+                           vals=validators.Numbers(min_value, max_value),
                            docstring="Actual slit opening width")
 
     @property