Fix Makefile escaping #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkilgore
requested review from
grymmjack,
flukiluke,
SteveMcNeill,
a740g and
RhoSigma-QB64
a740g
approved these changes
Feb 5, 2025
mkilgore
force-pushed
the
fix-makefile-escaping
branch
from
65814a2 to
1ba45ac
Compare
RhoSigma-QB64
approved these changes
Feb 10, 2025
There were several problems identified with the existing escaping for
calling `make`. This change completely redoes our approach to do the
correct escaping depending on the platform for all three levels of
escaping:
1. Makefile command and Shell invoation to run make:
a. Mac OS and Linux use single quotes. Existing single quotes in the
name are turned into '\'' to escape them.
b. Windows gets double quotes and no extra escaping
2. make invocation:
a. Quotes are escaped with `\"`, Dollar signs with '$$'
mkilgore
force-pushed
the
fix-makefile-escaping
branch
from
1ba45ac to
84cc9b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several problems identified with the existing escaping for calling
make- parenthesis at the end would get lost, dollar signs got expanded incorrectly, etc.. This change redoes the escaping and applies it correctly depending on the platform for all three levels of escaping:Makefile command and Shell invocation to run make:
a. Mac OS and Linux use single quotes. Existing single quotes in the name are turned into
'\''to escape them.b. Windows gets double quotes and no extra escaping.
make invocation:
a. Quotes are escaped with
\", Dollar signs with$$