Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve func__deflate() & func__inflate() #510

Merged
merged 2 commits into from
Jun 22, 2024

Conversation

a740g
Copy link
Contributor

@a740g a740g commented Jun 22, 2024

This PR does the following:

  • Optimizes func__deflate() & func__inflate() to eliminate unnecessary buffer copies. This results in a nice speed boost of upto 15% in some cases on my Ryzen 5600
  • Removes all unsafe usage of malloc() and free()
  • Handles a case where the user can pass negative values for originalSize which can potentially break qbs
  • Delegates the linking responsibility to the linker. This makes it possible to use the library from elsewhere with ease [needed for an upcoming PR]

@a740g a740g added bug Something isn't working enhancement New feature or request labels Jun 22, 2024
@a740g a740g self-assigned this Jun 22, 2024
@a740g a740g merged commit de49e25 into QB64-Phoenix-Edition:main Jun 22, 2024
4 checks passed
@a740g a740g deleted the compression-fixes branch June 22, 2024 08:10
a740g added a commit to a740g/QB64pe that referenced this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants