Create Windows GUI applications only when both DEP_CONSOLE_ONLY & DEP_CONSOLE are not defined #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CONSOLE are not defined
a740g
requested review from
grymmjack,
mkilgore,
SteveMcNeill and
RhoSigma-QB64
grymmjack
approved these changes
Apr 19, 2024
RhoSigma-QB64
approved these changes
Apr 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue where both
-mconsoleand-mwindowsflags are sent forDEP_CONSOLEapplications. Typically, this doesn't cause problems with MinGW, as it seems to prioritize-mconsole. However, LLVM MinGW gives preference to-mwindows, resulting in the complete disabling of the Windows console whenQB64pe.basis compiled with LLVM MinGW.This pull request addresses the final issue remaining from the list of issues I observed when using LLVM MinGW. By resolving this problem, we now have an opportunity to consider moving away from MinGW and adopting LLVM MinGW as the backend for all possible Windows targets in a future PR.