Fix mono-mode font rendering issues #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a740g
requested review from
grymmjack,
mkilgore,
SteveMcNeill and
RhoSigma-QB64
mkilgore
approved these changes
Apr 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue initially reported here.
The primary fix ensures accurate generation of mono glyph bitmaps for non-true-color screen modes. Similar adjustments have been made to the calculation of monospace width.
It also introduces a quality-of-life enhancement where the system now automatically detects whether the underlying font is fixed-width. If so, the
monospaceWidthvariable is appropriately updated. This allows_FONTWIDTHto accurately report the font width of fixed-width fonts, even in the absence of"monospace"usage.