DATA fixes #470
Merged
DATA fixes #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a740g
requested review from
grymmjack,
mkilgore,
SteveMcNeill,
RhoSigma-QB64 and
QB64Cobalt
RhoSigma-QB64
approved these changes
Mar 22, 2024
mkilgore
approved these changes
Mar 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue wherein the IDE appears to freeze on macOS when processing a BASIC source file containing a large number of
DATAstatements.A notable example of such a source file can be found here: tricky.bas
This PR primarily eliminates the resource-intensive string concatenation by instead allocating the necessary storage space for the string once and then copying substrings to their respective offsets.
This modification significantly reduces compile time. Moreover, this PR completely removes the dependency on
objcopy, thereby simplifyingDATAhandling across various platforms.