Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of the libqb refactoring, it should be a bit easier to review. The goals on this step:
list
andgfs
APIs are split into separate files.a. For the
gfs
API, I removed the global variables, replacing them with two accessor functionsgfs_get_fileno()
andgfs_get_file_struct()
. I also removed thegfs_file_win_struct
and simply placed theHANDLE
in thegfs_file_struct
(similar to thefstream
s for the stream-based interface).const char *
instead ofchar *
,#define
s that already exist)a.
-Wno-conversion-null
is used to suppress the thousands of warnings produced from passingNULL
for unused parameters, which leaves us with a very manageable amount and many which look like actual bugs.libqb.h
inaudio.cpp
, which shows some of the benefits of this refactoring.Fixes: #147
Fixes: #424