Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libqb refactor part 2 #455

Merged
merged 10 commits into from
Feb 17, 2024

Conversation

mkilgore
Copy link
Contributor

Part 2 of the libqb refactoring, it should be a bit easier to review. The goals on this step:

  1. The list and gfs APIs are split into separate files.
    a. For the gfs API, I removed the global variables, replacing them with two accessor functions gfs_get_fileno() and gfs_get_file_struct(). I also removed the gfs_file_win_struct and simply placed the HANDLE in the gfs_file_struct (similar to the fstreams for the stream-based interface).
  2. There are a start to changes to address warnings in the C++ (Ex. const char * instead of char *, #defines that already exist)
    a. -Wno-conversion-null is used to suppress the thousands of warnings produced from passing NULL for unused parameters, which leaves us with a very manageable amount and many which look like actual bugs.
  3. I removed usage of libqb.h in audio.cpp, which shows some of the benefits of this refactoring.

Fixes: #147
Fixes: #424

@mkilgore mkilgore force-pushed the libqb-refactor-part-2 branch from 1673f9b to a891a6b Compare February 17, 2024 01:05
@mkilgore mkilgore merged commit dafad71 into QB64-Phoenix-Edition:main Feb 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor gfs into separate source files in libqb/ Refactor list into a separate source file in libqb/
3 participants