Implement new file functions #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
RhoSigma-QB64
commented
Feb 16, 2024
RhoSigma-QB64
commented
- implements _READFILE$
- implements _WRITEFILE
- this fixes the wrong (additional) indention of the "false" part in precompiler $IF...$ELSE...$ENDIF blocks
- _READFILE$ - _WRITEFILE
a740g
reviewed
Feb 16, 2024
- rather than a function as suggested by @a740g
- adjust the case of legacy metacommands according to IDE layout settings
a740g
approved these changes
Feb 16, 2024
mkilgore
approved these changes
Feb 16, 2024
| len = ftell(file); // = file length | ||
| rewind(file); // rewind to start | ||
| cont = qbs_new(len, 1); // get new string for file contents | ||
| fread(cont -> chr, 1, len, file); |
There was a problem hiding this comment.
I think it's worth checking for an error after fread and fwrite, failures with them can happen for some somewhat common reasons (fwrite more than fread), and the user would have no way of knowing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.