Adler crc hash #444
Adler crc hash #444
Conversation
- disabling some unneeded features saves ~52KiB object size (55%)
- exposing the implementations in miniz for public use
- exposing the implementations in freetype for public use
| id.callname = "func__adler32" | ||
| id.args = 1 | ||
| id.arg = MKL$(STRINGTYPE - ISPOINTER) | ||
| id.ret = LONGTYPE - ISPOINTER |
There was a problem hiding this comment.
The return type for these functions should be ULONGTYPE.
| @@ -7,6 +7,16 @@ | |||
| #include "../../libqb.h" | |||
| #include "miniz.h" | |||
|
|
|||
| uint32_t func__adler32(qbs *text) { | |||
| if (!text->len) return 0; | |||
There was a problem hiding this comment.
Should it return 1 when the text is blank?
| @@ -9,5 +9,7 @@ | |||
|
|
|||
| struct qbs; | |||
|
|
|||
| uint32_t func__adler32(qbs *text); | |||
There was a problem hiding this comment.
Rather than put them in font.h and compression.h I think it would make more sense to add a new hashing.h and put them in there.
I agree. A simple test with a minimum of 6 function calls in total should be conducted. For each of the 3 functions, we need two tests: one with an empty string and another with some pre-defined string. Also like @mkilgore pointed, adler32 for an empty string should return a 1. |
- return type is uint32_t in C/C++ and ULONGTYPE in QB64 - adler32 must return one (1) on an empty input
- hopefully
- ok, that was my fault?, no it wasn't, - console is ignoring trailing space when copying text from it
| /// @param text The message to build the MD5 hash of | ||
| /// @return The generated MD5 hash as hexadecimal string | ||
| qbs *func__md5(qbs *text) { | ||
| { |
There was a problem hiding this comment.
Not that it really matters, but we can get rid of the extra braces.
This 1st PR will implement the new functions _ADLER32, _CRC32 and _MD5$, after it is successfully merged I'll start a 2nd PR which then exchanges the use of the recently added GetCRC32&() BASIC FUNCTION (utilities/strings.bas) with _CRC32 or probably even _MD5$ and remove that BASIC FUNCTION again.