-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GLEW and FreeGLUT refactor and cleanup #441
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RhoSigma-QB64
approved these changes
Jan 30, 2024
SteveMcNeill
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a refactoring effort to cleanup and consolidate
GLEW
andFreeGLUT
dependencies. The goal is to improve code organization and simplify the handling ofGLEW
andFreeGLUT
dependencies.Major Changes
FreeGLUT
to version 2.8.1 (latest 2.x version).GLEW
to version 2.2.0.GLEW
fromlibqb
.FreeGLUT
with comments (starting withQB64-PE: ...
).Notes
While the pull request indicates 1135 files changed, a majority of these modifications involve the removal of dead and redundant files. This significantly streamlines the content in
internal/c/parts/core
. The compilation structure forFreeGLUT
andGLEW
remains consistent, utilizing flat-directory compilation. Several non-critical custom changes toFreeGLUT
were reversed, achieving the same functionality through makefile logic where possible.What's Next?
This refactoring sets the stage for a smoother transition to
FreeGLUT
version 3.x or alternative libraries such asGLFW
version 3.x.FreeGLUT
3.x:FreeGLUT
3.x.FreeGLUT
3.x lacks a callback for file drag-and-drop, necessitating investigation if transitioning to 3.x without altering library code.GLFW
:GLFW
demands more effort, as it does not control the event loop. However, this offers precise timing and lower latency.