Fix to Mod and \ in CONST #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the sample code below: Const a = 5 Mod 2.8 Const b = 5 \ 2.8 Print a; "="; 5 Mod 2.8 Print b; "="; 5 \ 2.8 Old output was wrong. Patch should make the CONST values the same as what QB64 normally generates for us.
a740g
approved these changes
Oct 15, 2023
mkilgore
approved these changes
Oct 15, 2023
There was a problem hiding this comment.
LGTM :)
A bit of history: This bug was introduced by me in #126, a fix for QB64Official/qb64#4. The issue here was then reported in QB64Official/qb64#53 (and noticed by us) and recently fixed over in QB64Official in QB64Official/qb64#54 by simply reverting my old change and reintroducing the bug in QB64Official/qb64#4.
Using _Round() instead of FIX() is the proper solution as it matches what QB64 does when converting the Double argument to Mod into an integer, ensuring that the = 0 comparison is accurate while not changing the behavior of Mod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the sample code below:
Const a = 5 Mod 2.8
Const b = 5 \ 2.8
Print a; "="; 5 Mod 2.8
Print b; "="; 5 \ 2.8
Old output was wrong. Patch should make the CONST values the same as what QB64 normally generates for us.