Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menu item Run #Only (No EXE) #385

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Conversation

a740g
Copy link
Contributor

@a740g a740g commented Oct 5, 2023

This fixes the error MENU ITEM [Run #Only (No EXE) NOT IMPLEMENTED! that occurs because the string below

IF menu$(m, s) = "Run only (No exe)" THEN

does not match with

menu$(m, i) = "Run #Only (No EXE)": i = i + 1

I changed the menu string in an earlier PR not knowing that we compare the string later to see if the menu was clicked.
We should seriously consider consolidating and moving these strings to CONSTs or DATA to avoid these issues in the future.

This issue was reported here: https://qb64phoenix.com/forum/showthread.php?tid=2063&pid=20329#pid20329

@a740g a740g added the bug Something isn't working label Oct 5, 2023
@a740g a740g self-assigned this Oct 5, 2023
@a740g a740g merged commit 328b14c into QB64-Phoenix-Edition:main Oct 5, 2023
@a740g a740g mentioned this pull request Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants