Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize GenerateWaveform #186

Closed
a740g opened this issue Sep 21, 2022 · 1 comment · Fixed by #279
Closed

Optimize GenerateWaveform #186

a740g opened this issue Sep 21, 2022 · 1 comment · Fixed by #279
Labels
enhancement New feature or request

Comments

@a740g
Copy link
Contributor

a740g commented Sep 21, 2022

GenerateWaveform in audio.cpp generates stereo waveform which is used by SOUND and PLAY. SOUND and PLAY have no stereo capabilities and hence generating stereo waveform is a waste of memory and processing resources.

GenerateWaveform should be rewritten to generate mono waveform instead.
@a740g a740g added the enhancement New feature or request label Sep 21, 2022
@a740g a740g mentioned this issue Oct 25, 2022
Closed
@barcoboy
Copy link

As I mentioned in #217, the sound generated by PLAY is a triangle waveform, where QB45 generates a near square waveform.

a740g added a commit to a740g/QB64pe that referenced this issue Dec 22, 2022
@a740g
Address QB64-Phoenix-Edition#186
a72f802
@a740g a740g mentioned this issue Dec 30, 2022
Merged
@a740g a740g linked a pull request Dec 30, 2022 that will close this issue
Miniaudio fixes #279
Merged
@a740g a740g closed this as completed in #279 Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Miniaudio fixes a740g/QB64pe
2 participants
@barcoboy @a740g