Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] correct bugs with gw barycenter on 1 input #628

Merged
merged 7 commits into from
Jun 20, 2024

Conversation

cedricvincentcuaz
Copy link
Collaborator

@cedricvincentcuaz cedricvincentcuaz commented Jun 17, 2024

Types of changes

  • Depreciating feature for (F)GW barycenter functions : structures Cs[i], features Ys[i] and/or weights ps[i] are lists and should be arrays from a supported backend (e.g numpy).".

  • Allows to support computation of (F)GW barycenters over 1 input and not just several ones.

Motivation and context / Related issue

How has this been tested (if it applies)

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.68%. Comparing base (246de6b) to head (73fd03f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #628      +/-   ##
==========================================
+ Coverage   96.67%   96.68%   +0.01%     
==========================================
  Files          85       85              
  Lines       16836    16890      +54     
==========================================
+ Hits        16276    16330      +54     
  Misses        560      560              

@rflamary rflamary changed the title [WIP] correct bugs with gw barycenter on 1 input [MRG] correct bugs with gw barycenter on 1 input Jun 20, 2024
@rflamary rflamary merged commit 1f7d547 into PythonOT:master Jun 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants