Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] fix grad sign sr(F)GW with KL loss #611

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

cedricvincentcuaz
Copy link
Collaborator

@cedricvincentcuaz cedricvincentcuaz commented Mar 4, 2024

Types of changes

Fix same issue than in PR #610 for sr(F)GW.

Motivation and context / Related issue

How has this been tested (if it applies)

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Merging #611 (dc6c3d8) into master (3e05385) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #611   +/-   ##
=======================================
  Coverage   96.78%   96.78%           
=======================================
  Files          77       77           
  Lines       16027    16027           
=======================================
  Hits        15511    15511           
  Misses        516      516           

@cedricvincentcuaz cedricvincentcuaz merged commit 63e44e5 into PythonOT:master Mar 4, 2024
15 checks passed
@cedricvincentcuaz cedricvincentcuaz deleted the grad branch April 16, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant