-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DA] Sinkhorn L1L2 transport to work on JAX #587
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #587 +/- ##
=======================================
Coverage 96.74% 96.75%
=======================================
Files 77 77
Lines 15911 15939 +28
=======================================
+ Hits 15393 15421 +28
Misses 518 518 |
This was referenced Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
All operations required for
SinkhornL1l2Transport
to work on JAX are properly vectorized, including those implemented in theBaseTransport
. In shortlabels_to_masks
helper with corresponding testsnan_to_num
Motivation and context / Related issue
The next step towards making domain adaptation methods to work on JAX backend, continues the work started with #507.
How has this been tested (if it applies)
test_sinkhorn_l1l2_transport_class
test doesn't skip JAX backendlabel_normalization
andlabels_to_masks
helpersPR checklist
Additional Context
Working on the implementation I spotted the following (potential issue). It seems that the tests for semi-supervised DA, in fact, do not cover semi-supervised use case. They test the different between unsupervised (no labels for target) and supervised (target labels are available). For the
test_sinkhorn_l1l2_transport_class
specifically I did update the implementation to use partially masked labels for targets (seeotda_semi
). Does it covers the expected functionality correctly?