Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] BAPG solvers for GW and FGW #581

Merged
merged 10 commits into from
Nov 30, 2023
Merged

Conversation

cedricvincentcuaz
Copy link
Collaborator

@cedricvincentcuaz cedricvincentcuaz commented Nov 24, 2023

Types of changes

  • Add Bregman alternated projected gradient solvers for GW and FGW via functions: BAPG_gromov_wasserstein, BAPG_gromov_wasserstein2, BAPG_fused_gromov_wasserstein, BAPG_fused_gromov_wasserstein2

  • update example with FGW solvers comparison.

Motivation and context / Related issue

  • Keep up with the (F)GW literature.

How has this been tested (if it applies)

  • add tests test_BAPG_fgw, test_BAPG_gromov. Modified in place test_entropic_gromov_dtype_device, test_entropic_fgw_dtype_device.

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #581 (655a95e) into master (f809253) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
+ Coverage   96.66%   96.71%   +0.05%     
==========================================
  Files          75       75              
  Lines       15416    15651     +235     
==========================================
+ Hits        14902    15137     +235     
  Misses        514      514              

@cedricvincentcuaz cedricvincentcuaz changed the title [WIP] BAPG solvers for GW and FGW [MRG] BAPG solvers for GW and FGW Nov 27, 2023
@rflamary rflamary merged commit 55a851e into PythonOT:master Nov 30, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants