Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Avoid changing precision in the backend #572

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

kachayev
Copy link
Collaborator

@kachayev kachayev commented Nov 10, 2023

Types of changes

Fix previously added (see PR #507) precision change when computing norm on the PyTorch backend.

Motivation and context / Related issue

Precision change is not necessary, and fails on devices which don't have support for double precision.

Related discussion #570.

How has this been tested (if it applies)

n/a

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #572 (7dc0579) into master (a56e1b2) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #572   +/-   ##
=======================================
  Coverage   96.51%   96.51%           
=======================================
  Files          67       67           
  Lines       14821    14821           
=======================================
  Hits        14304    14304           
  Misses        517      517           

@rflamary rflamary changed the title Avoid changing precision in the backend [MRG] Avoid changing precision in the backend Nov 10, 2023
@rflamary rflamary merged commit 91c67fb into PythonOT:master Nov 10, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants