Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] correct independence of fgw barycenters to init #566

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

cedricvincentcuaz
Copy link
Collaborator

Types of changes

  • correct independence of fgw barycenters to init by changing performing the 1st barycenter update after the computing the 1st OT matrices.
  • Removed some unnecessary operations when fixed_features=True and/or warmstart=False.

Motivation and context / Related issue

How has this been tested (if it applies)

  • already handled by existing tests.

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #566 (882202c) into master (1682b60) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
+ Coverage   96.49%   96.51%   +0.01%     
==========================================
  Files          67       67              
  Lines       14816    14821       +5     
==========================================
+ Hits        14297    14304       +7     
+ Misses        519      517       -2     

@rflamary rflamary changed the title [WIP] correct independence of fgw barycenters to init [MRG] correct independence of fgw barycenters to init Nov 8, 2023
Copy link
Collaborator

@rflamary rflamary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cedricvincentcuaz a few comments and we can merge

ot/gromov/_gw.py Outdated Show resolved Hide resolved
ot/gromov/_gw.py Outdated Show resolved Hide resolved
ot/gromov/_gw.py Outdated Show resolved Hide resolved
test/test_gromov.py Outdated Show resolved Hide resolved
test/test_gromov.py Outdated Show resolved Hide resolved
@cedricvincentcuaz
Copy link
Collaborator Author

Thank you for your feedback @rflamary. I took into account your comments.

@rflamary rflamary merged commit a56e1b2 into PythonOT:master Nov 9, 2023
13 checks passed
@cedricvincentcuaz cedricvincentcuaz deleted the issues branch November 11, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants