[MRG] update LP barycenter with new scipy solvers #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #537 +/- ##
=======================================
Coverage 96.38% 96.38%
=======================================
Files 67 67
Lines 14389 14389
=======================================
Hits 13869 13869
Misses 520 520 |
rflamary
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Scipy has since 1.6 new C++ LP solvers that can handle very well sparse matrices and lead to better solutions.
This PR bump the scipy requirement and use now as default solver for LP barycenter the new "highs-ipm" solver that is more than 10 times faster on the example in the documentation
Motivation and context / Related issue
How has this been tested (if it applies)
PR checklist