Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Tiny fix in SSNB #535

Merged
merged 31 commits into from
Oct 18, 2023
Merged

[MRG] Tiny fix in SSNB #535

merged 31 commits into from
Oct 18, 2023

Conversation

eloitanguy
Copy link
Collaborator

@eloitanguy eloitanguy commented Oct 18, 2023

Types of changes

Added a forgotten factor for the computation of the barycentric mapping (initialisation for SSNB)
Removed the cell about the barycentric mapping in the SSNB example: it had the same typo and is unnecessary.

How has this been tested (if it applies)

Still pytest covered + reran example for illustration.

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #535 (b3578f0) into master (8a4a5a6) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #535   +/-   ##
=======================================
  Coverage   96.31%   96.31%           
=======================================
  Files          67       67           
  Lines       14136    14136           
=======================================
  Hits        13615    13615           
  Misses        521      521           

@rflamary rflamary merged commit 57eda61 into PythonOT:master Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants