[Fix] Prevent line search from evaluating cost outside of the interpolation range #504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
alpha_min
parameter forot.optim.line_search_armijo
now has default value 0. Additional boundary condition check is introduce inside of line search callback.Motivation and context / Related issue
PR closes #502, you can find detailed analysis of the problem there.
How has this been tested (if it applies)
Existing
test_sinkhorn_l1l2_transport_class
test case now has explicit check for "no warnings".PR checklist