-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] add the sparsity-constrained optimal transport funtionality and example #459
[MRG] add the sparsity-constrained optimal transport funtionality and example #459
Conversation
Question: In the |
Thanks! I updated the pull request. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #459 +/- ##
==========================================
- Coverage 94.92% 94.91% -0.02%
==========================================
Files 31 32 +1
Lines 6879 6942 +63
==========================================
+ Hits 6530 6589 +59
- Misses 349 353 +4 |
Hello thanks for the PR, we will do a code reveiw ASAP! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tian Lin! Two other comments below.
Also small comment, since you are using functions from |
Hey both, thanks! I incorporated the suggestions. Note that I only added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello @liutianlin0121 ,
Thanks so much for the PR. I still have a few comments before merging but we are neraly there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @liutianlin0121 could you please add you PR to the RELEASES.md file with a short description of the new feature? I thank after that we can merge.
Types of changes
Add a new optimal transport functionality and an example.
Motivation and context / Related issue
"Sparsity-constrained optimal transport" is a variant of the optimal transport problem that provides direct control over the number of non-zero values allowed in the optimal plan. This formulation may be of interest to users of POT. For more information, please refer to the following paper: https://openreview.net/forum?id=yHY9NbQJ5BP.
How has this been tested (if it applies)
The tests check that the marginal constraints of the optimal plans are approximately satisfied, and that the sparsity constraints are satisfied.
PR checklist