Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Make partial_wasserstein, partial_wasserstein2 and entropic_partial_wasserstein work with backend #449

Merged
merged 15 commits into from
Mar 21, 2023

Conversation

antoinecollas
Copy link
Contributor

@antoinecollas antoinecollas commented Mar 20, 2023

Types of changes

The functions partial_wasserstein, partial_wasserstein2 and entropic_partial_wasserstein have been adapted to work with any backend (not only numpy) and are tested with torch. In particular, backward passes through them are tested.

Motivation and context / Related issue

The functions mentioned above did not leverage the nx backend.

How has this been tested (if it applies)

Forward and backward passes of the functions mentioned are tested with torch.

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

@antoinecollas antoinecollas changed the title Make partial_wasserstein, partial_wasserstein2 and entropic_partial_wasserstein work with torch [MRG] Make partial_wasserstein, partial_wasserstein2 and entropic_partial_wasserstein work with torch Mar 20, 2023
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #449 (93c4962) into master (c48cd76) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   94.80%   94.85%   +0.05%     
==========================================
  Files          30       30              
  Lines        6762     6770       +8     
==========================================
+ Hits         6411     6422      +11     
+ Misses        351      348       -3     

@rflamary rflamary changed the title [MRG] Make partial_wasserstein, partial_wasserstein2 and entropic_partial_wasserstein work with torch [MRG] Make partial_wasserstein, partial_wasserstein2 and entropic_partial_wasserstein work with backend Mar 21, 2023
@rflamary rflamary merged commit b9ed7b1 into PythonOT:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants