-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Make partial_wasserstein, partial_wasserstein2 and entropic_partial_wasserstein work with backend #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinecollas
changed the title
Make partial_wasserstein, partial_wasserstein2 and entropic_partial_wasserstein work with torch
[MRG] Make partial_wasserstein, partial_wasserstein2 and entropic_partial_wasserstein work with torch
Mar 20, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #449 +/- ##
==========================================
+ Coverage 94.80% 94.85% +0.05%
==========================================
Files 30 30
Lines 6762 6770 +8
==========================================
+ Hits 6411 6422 +11
+ Misses 351 348 -3 |
rflamary
changed the title
[MRG] Make partial_wasserstein, partial_wasserstein2 and entropic_partial_wasserstein work with torch
[MRG] Make partial_wasserstein, partial_wasserstein2 and entropic_partial_wasserstein work with backend
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
The functions
partial_wasserstein
,partial_wasserstein2
andentropic_partial_wasserstein
have been adapted to work with any backend (not only numpy) and are tested with torch. In particular, backward passes through them are tested.Motivation and context / Related issue
The functions mentioned above did not leverage the
nx
backend.How has this been tested (if it applies)
Forward and backward passes of the functions mentioned are tested with torch.
PR checklist