Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Remove redundant abs() #448

Merged
merged 2 commits into from
Mar 21, 2023
Merged

[MRG] Remove redundant abs() #448

merged 2 commits into from
Mar 21, 2023

Conversation

chaosink
Copy link
Contributor

@chaosink chaosink commented Mar 18, 2023

Types of changes

Remove redundant computation.

Motivation and context / Related issue

Remove redundant computation.
No related issue.

How has this been tested (if it applies)

No need to test obviously.

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #448 (a1512af) into master (5835016) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #448   +/-   ##
=======================================
  Coverage   94.80%   94.80%           
=======================================
  Files          30       30           
  Lines        6762     6762           
=======================================
  Hits         6411     6411           
  Misses        351      351           

@rflamary
Copy link
Collaborator

Hello,

please could you add your PR to teh releases.md file witha short decsription of what it did?

@rflamary rflamary changed the title Remove redundant abs() [MRG] Remove redundant abs() Mar 20, 2023
@chaosink
Copy link
Contributor Author

I thought the change is too tiny to be recorded in RELEASES.md.

Anyway, now it's added into RELEASES.md.

Thanks!

@rflamary rflamary merged commit c48cd76 into PythonOT:master Mar 21, 2023
@chaosink chaosink deleted the patch-1 branch March 21, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants