Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Fix warning bug in sinkhorn2 #417

Merged
merged 5 commits into from
Dec 23, 2022

Conversation

arincbulgur
Copy link
Contributor

@arincbulgur arincbulgur commented Dec 15, 2022

Types of changes

warn argument was not passed downstream sinkhorn_knopp and sinkhorn_log methods and hence it was not possible to suppress warnings appearing inside those methods. It's fixed now.

Motivation and context / Related issue

How has this been tested (if it applies)

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

@rflamary
Copy link
Collaborator

Hello @arincbulgur and thank you for the PR.

Could you please update the test_convergence_warning test in test/test_bregman.py that check that the warning is there (and basically also chect that it is not there when warn=Falsein the same tets function)?

@rflamary rflamary changed the title [MRG] Fix warning bug in sinkhorn2 [WIP] Fix warning bug in sinkhorn2 Dec 19, 2022
@rflamary rflamary changed the title [WIP] Fix warning bug in sinkhorn2 [MRG] Fix warning bug in sinkhorn2 Dec 23, 2022
@rflamary
Copy link
Collaborator

Thanks @arincbulgur , merging now!

@rflamary rflamary merged commit 058d275 into PythonOT:master Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants