Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Replaces numpy compiler with setuptools #409

Merged
merged 4 commits into from
Nov 21, 2022

Conversation

ncassereau
Copy link
Contributor

@ncassereau ncassereau commented Nov 21, 2022

Types of changes

Removes numpy ccompiler dependency. Replaces it with setuptools. The solution is based on scikit-learn (https://github.com/scikit-learn/scikit-learn/blob/main/sklearn/_build_utils/pre_build_helpers.py)

Motivation and context / Related issue

Resolves #408.

How has this been tested (if it applies)

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #409 (7c7d72f) into master (e433775) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #409   +/-   ##
=======================================
  Coverage   93.97%   93.98%           
=======================================
  Files          22       22           
  Lines        5929     5920    -9     
=======================================
- Hits         5572     5564    -8     
+ Misses        357      356    -1     

@ncassereau ncassereau marked this pull request as ready for review November 21, 2022 13:08
@ncassereau ncassereau changed the title [WIP] Replaces numpy compiler with setuptools [MRG] Replaces numpy compiler with setuptools Nov 21, 2022
@rflamary rflamary merged commit fa0d4f2 into PythonOT:master Nov 21, 2022
@ncassereau ncassereau deleted the numpy_ccompiler_deprecation branch November 21, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numpy C-Compiler deprecation prevents POT from building
2 participants