Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Proper links in release file in documentation #350

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Conversation

rflamary
Copy link
Collaborator

@rflamary rflamary commented Feb 23, 2022

Types of changes

The objective is to have links to Issues and PR when in the Release page in the docuemnation.

It is done with a simple sed before building the doc

Motivation and context / Related issue

How has this been tested (if it applies)

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #350 (0e580cb) into master (3302cd4) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #350      +/-   ##
==========================================
+ Coverage   93.59%   93.63%   +0.03%     
==========================================
  Files          22       22              
  Lines        5591     5591              
==========================================
+ Hits         5233     5235       +2     
+ Misses        358      356       -2     

@rflamary rflamary changed the title [WIP] Proper links in release file in documentation [MRG] Proper links in release file in documentation Feb 23, 2022
@rflamary rflamary merged commit 1781472 into master Feb 23, 2022
@rflamary rflamary deleted the url_doc_release branch February 23, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant