Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Build POT against oldest-supported-numpy (local PR) #349

Merged
merged 11 commits into from
Feb 23, 2022

Conversation

rflamary
Copy link
Collaborator

@rflamary rflamary commented Feb 22, 2022

Types of changes

this PR is a local (branch) version of #347 that will actually run the wheel building.

Motivation and context / Related issue

Fixes #346

How has this been tested (if it applies)

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

@rflamary rflamary changed the title [WIP] Build POT against oldest-supported-numpy [WIP] Build POT against oldest-supported-numpy (local PR) Feb 22, 2022
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #349 (aac1a2a) into master (50c0f17) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
- Coverage   93.63%   93.59%   -0.04%     
==========================================
  Files          22       22              
  Lines        5591     5591              
==========================================
- Hits         5235     5233       -2     
- Misses        356      358       +2     

Copy link
Contributor

@davidghiurco davidghiurco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding suggestions to reconcile build restrictions with python_requires=">=3.6" in setup.py

setup.py Outdated Show resolved Hide resolved
.github/workflows/build_wheels.yml Outdated Show resolved Hide resolved
@rflamary rflamary changed the title [WIP] Build POT against oldest-supported-numpy (local PR) [MRG] Build POT against oldest-supported-numpy (local PR) Feb 23, 2022
@rflamary rflamary merged commit 3302cd4 into master Feb 23, 2022
@davidghiurco
Copy link
Contributor

@rflamary I noticed you might want to apply the changes made in build_wheels.yml to build_wheels_weekly.yml: https://github.com/PythonOT/POT/blob/master/.github/workflows/build_wheels_weekly.yml#L42-L43

@davidghiurco
Copy link
Contributor

And if you do apply those changes, you might want to add to release notes that Python 3.6 support is back.

@rflamary
Copy link
Collaborator Author

We are not adding python3.6 support back because python 3.6 is not supported and we should not promote old unsupported code. Actually the wheels are not builded for 3.6 because it is not supported anymore and the CI does not test 3.6. We are just allowing the user to install it even if it is not supported.

I'll update the weekly the wheels in an other PR.

@rflamary rflamary deleted the oldest-numpy branch April 11, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants