-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Build POT against oldest-supported-numpy (local PR) #349
Conversation
…ng the meta-package: https://pypi.org/project/oldest-supported-numpy/ - build all wheels
…ved Python 3.6 support - build all wheels
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
==========================================
- Coverage 93.63% 93.59% -0.04%
==========================================
Files 22 22
Lines 5591 5591
==========================================
- Hits 5235 5233 -2
- Misses 356 358 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding suggestions to reconcile build restrictions with python_requires=">=3.6"
in setup.py
@rflamary I noticed you might want to apply the changes made in |
And if you do apply those changes, you might want to add to release notes that Python 3.6 support is back. |
We are not adding python3.6 support back because python 3.6 is not supported and we should not promote old unsupported code. Actually the wheels are not builded for 3.6 because it is not supported anymore and the CI does not test 3.6. We are just allowing the user to install it even if it is not supported. I'll update the weekly the wheels in an other PR. |
Types of changes
this PR is a local (branch) version of #347 that will actually run the wheel building.
Motivation and context / Related issue
Fixes #346
How has this been tested (if it applies)
PR checklist