-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Domain adaptation and unbalanced solvers with backend support #343
Merged
rflamary
merged 49 commits into
PythonOT:master
from
ncassereau:domain_adaptation_backend
Mar 24, 2022
Merged
[MRG] Domain adaptation and unbalanced solvers with backend support #343
rflamary
merged 49 commits into
PythonOT:master
from
ncassereau:domain_adaptation_backend
Mar 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #343 +/- ##
==========================================
+ Coverage 93.63% 93.72% +0.08%
==========================================
Files 22 22
Lines 5595 5753 +158
==========================================
+ Hits 5239 5392 +153
- Misses 356 361 +5 |
rflamary
changed the title
Domain adaptation with backend support
[WIP] Domain adaptation with backend support
Feb 4, 2022
…(which will change default indexing)
rflamary
changed the title
[WIP] Domain adaptation with backend support
[WIP] Domain adaptation and unbalanced solvers with backend support
Feb 9, 2022
ncassereau
changed the title
[WIP] Domain adaptation and unbalanced solvers with backend support
[MRG] Domain adaptation and unbalanced solvers with backend support
Feb 9, 2022
rflamary
reviewed
Mar 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an impressive PR good work @ncassereau-idris
I'm still a bit hesitant about the type output that ot.emd should return but in the meantime here are a few comments
…istogram's dtype, defaulting to cost matrix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Introducing backend support for da.py
Motivation and context / Related issue
GPU support and Pytorch and automatic differentation, ...
Note that it does not support jax and tensorflow yet because those two backends do not allow item assignment.
How has this been tested (if it applies)
PR checklist