Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Add weak OT solver #341

Merged
merged 11 commits into from
Feb 2, 2022
Merged

[MRG] Add weak OT solver #341

merged 11 commits into from
Feb 2, 2022

Conversation

rflamary
Copy link
Collaborator

@rflamary rflamary commented Jan 28, 2022

Types of changes

  • Add weak OT solver
  • Add tests for solver and backends
  • Add example for weak OT in doc

Motivation and context / Related issue

How has this been tested (if it applies)

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #341 (effe32f) into master (71a57c6) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
+ Coverage   93.08%   93.23%   +0.15%     
==========================================
  Files          21       22       +1     
  Lines        5218     5250      +32     
==========================================
+ Hits         4857     4895      +38     
+ Misses        361      355       -6     

@rflamary rflamary changed the title [WIP] Add weak OT solver [MRG] Add weak OT solver Jan 31, 2022
@rflamary rflamary requested a review from ncourty January 31, 2022 16:01
Copy link
Collaborator

@ncourty ncourty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the nice work rémi !

examples/others/plot_WeakOT_VS_OT.py Outdated Show resolved Hide resolved
ot/weak.py Show resolved Hide resolved
ot/weak.py Outdated Show resolved Hide resolved
ot/weak.py Outdated Show resolved Hide resolved
test/test_weak.py Show resolved Hide resolved
@rflamary rflamary requested a review from ncourty February 2, 2022 07:46
ot/weak.py Show resolved Hide resolved
@rflamary rflamary merged commit a5e0f0d into master Feb 2, 2022
@rflamary rflamary deleted the weak_ot branch February 2, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants