-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] GW dictionary learning #319
Merged
rflamary
merged 26 commits into
PythonOT:master
from
cedricvincentcuaz:gw_dictionarylearning
Feb 11, 2022
Merged
[MRG] GW dictionary learning #319
rflamary
merged 26 commits into
PythonOT:master
from
cedricvincentcuaz:gw_dictionarylearning
Feb 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
==========================================
+ Coverage 93.20% 93.59% +0.39%
==========================================
Files 22 22
Lines 5250 5591 +341
==========================================
+ Hits 4893 5233 +340
- Misses 357 358 +1 |
…ferentiable functions
…entcuaz/POT into gw_dictionarylearning
rflamary
reviewed
Feb 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the PR, here are a few comment about variable names and testing that should be taken into account
…entcuaz/POT into gw_dictionarylearning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and context / Related issue
new functions/ new file:
main:
hidden:
added features to existing functions used in main new functions:
How has this been tested (if it applies)
dictionary learning functions tested in plot_gromov_wasserstein_dictionary_learning.py. Dependency with backend tested by providing either numpy or pytorch tensors as inputs.
Checklist