Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] SinkhornL1L2 bug solve #313

Merged
merged 3 commits into from
Nov 17, 2021
Merged

Conversation

ncassereau
Copy link
Contributor

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and context / Related issue

Resolves #311

How has this been tested (if it applies)

Also setting a minimum value for alpha from now on.

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document.
  • All tests passed, and additional code has been covered with new tests.

@ncassereau ncassereau marked this pull request as draft November 17, 2021 13:45
@ncassereau ncassereau changed the title [WIP] SinkhornL1L2 bug solve [MRG] SinkhornL1L2 bug solve Nov 17, 2021
@ncassereau ncassereau marked this pull request as ready for review November 17, 2021 14:04
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #313 (9b94074) into master (e235b08) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #313   +/-   ##
=======================================
  Coverage   93.39%   93.39%           
=======================================
  Files          21       21           
  Lines        4887     4890    +3     
=======================================
+ Hits         4564     4567    +3     
  Misses        323      323           

@rflamary rflamary merged commit 8b9e641 into PythonOT:master Nov 17, 2021
@ncassereau ncassereau deleted the bug_sinkhornl1l2 branch November 18, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An Error (RuntimeWarning: invalid value encountered in log) in ot.da.SinkhornL1lL2 after some iterations
2 participants