Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Make gromov loss differentiable wrt matrices and weights #302

Merged
merged 13 commits into from
Nov 4, 2021

Conversation

rflamary
Copy link
Collaborator

@rflamary rflamary commented Nov 3, 2021

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and context / Related issue

Differentiable gromov will make it easier to use with gradient descent algorithm with the backends.

How has this been tested (if it applies)

All existing unit tests + new testing tat gradients are computed

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document.
  • All tests passed, and additional code has been covered with new tests.

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #302 (a0698d4) into master (9c6ac88) will increase coverage by 0.04%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
+ Coverage   93.37%   93.41%   +0.04%     
==========================================
  Files          21       21              
  Lines        4799     4848      +49     
==========================================
+ Hits         4481     4529      +48     
- Misses        318      319       +1     

@rflamary rflamary changed the title [WIP] Make gromov loss differentiable wrt matrices and weights [MRG] Make gromov loss differentiable wrt matrices and weights Nov 4, 2021
@rflamary rflamary merged commit 2fe69eb into master Nov 4, 2021
@rflamary rflamary deleted the gromov_diff branch November 4, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant