Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Backend for gromov #294

Merged
merged 27 commits into from
Nov 2, 2021
Merged

Conversation

ncassereau
Copy link
Contributor

@ncassereau ncassereau commented Oct 27, 2021

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and context / Related issue

Implementation of gromov.py using the backend system. Also includes tiny modifications of other files (ex. correction of bregman.py)

How has this been tested (if it applies)

Tested on Linux with all 3 backends

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document.
  • All tests passed, and additional code has been covered with new tests.

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #294 (cb1c014) into master (0cb2b2e) will increase coverage by 0.09%.
The diff coverage is 96.83%.

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
+ Coverage   93.10%   93.20%   +0.09%     
==========================================
  Files          20       20              
  Lines        4237     4370     +133     
==========================================
+ Hits         3945     4073     +128     
- Misses        292      297       +5     

ot/bregman.py Outdated Show resolved Hide resolved
ot/bregman.py Outdated Show resolved Hide resolved
@rflamary rflamary marked this pull request as ready for review October 29, 2021 14:43
@rflamary rflamary changed the title [WIP] Backend for gromov [MRG] Backend for gromov Oct 29, 2021
@rflamary rflamary merged commit a335324 into PythonOT:master Nov 2, 2021
@ncassereau ncassereau deleted the gromov_backend branch November 3, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants