Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] GPU bugs solve #288

Merged
merged 5 commits into from
Sep 30, 2021
Merged

[MRG] GPU bugs solve #288

merged 5 commits into from
Sep 30, 2021

Conversation

ncassereau
Copy link
Contributor

@ncassereau ncassereau commented Sep 29, 2021 •
edited
Loading

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and context / Related issue

Resolves #284, Resolves #287
Tests on GPU were failing

How has this been tested (if it applies)

Tested on Linux

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document.
  • All tests passed, and additional code has been covered with new tests.

@rflamary rflamary merged commit 14c30d4 into PythonOT:master Sep 30, 2021
@ncassereau ncassereau deleted the GPU_sinkhorn_lpl1_typerror branch October 1, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests on GPU failing ot.gpu.da.sinkhorn_lpl1: TypeError: Expected list, got tuple
2 participants
@ncassereau @rflamary