Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Backend for optim #282

Merged
merged 15 commits into from
Oct 25, 2021
Merged

[MRG] Backend for optim #282

merged 15 commits into from
Oct 25, 2021

Conversation

ncassereau
Copy link
Contributor

@ncassereau ncassereau commented Sep 13, 2021

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and context / Related issue

Implementation of optim.py using the backend system.

How has this been tested (if it applies)

Tested on Linux with all 3 backends

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document.
  • All tests passed, and additional code has been covered with new tests.

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #282 (05ed992) into master (7a65086) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
+ Coverage   92.98%   93.03%   +0.05%     
==========================================
  Files          20       20              
  Lines        4122     4152      +30     
==========================================
+ Hits         3833     3863      +30     
  Misses        289      289              

@ncassereau ncassereau changed the title [WIP] Backend for optim [MRG] Backend for optim Sep 14, 2021
@rflamary rflamary merged commit 76450dd into PythonOT:master Oct 25, 2021
@ncassereau ncassereau deleted the optim_backend branch October 26, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants