Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Bregman backend #280

Merged
merged 27 commits into from
Oct 25, 2021
Merged

[MRG] Bregman backend #280

merged 27 commits into from
Oct 25, 2021

Conversation

ncassereau
Copy link
Contributor

@ncassereau ncassereau commented Sep 10, 2021

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and context / Related issue

Bregman file now fully uses the backend feature.

How has this been tested (if it applies)

Tested on Jean Zay (Linux) with all 3 backends

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document.
  • All tests passed, and additional code has been covered with new tests.

@ncassereau ncassereau changed the title Bregman backend [WIP] Bregman backend Sep 10, 2021
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #280 (0ad21b1) into master (7af8c21) will increase coverage by 0.18%.
The diff coverage is 94.14%.

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
+ Coverage   92.79%   92.98%   +0.18%     
==========================================
  Files          20       20              
  Lines        3944     4122     +178     
==========================================
+ Hits         3660     3833     +173     
- Misses        284      289       +5     

@ncassereau ncassereau changed the title [WIP] Bregman backend [MRG] Bregman backend Sep 14, 2021
Copy link
Collaborator

@rflamary rflamary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's good a few more comments and we can merge.

Thank you for the wonderful work on the documentation.

ot/backend.py Show resolved Hide resolved
ot/backend.py Outdated Show resolved Hide resolved
ot/backend.py Show resolved Hide resolved
@rflamary rflamary merged commit 7a65086 into PythonOT:master Oct 25, 2021
@ncassereau ncassereau deleted the bregman_backend branch October 26, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants