Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Regularization path for l2 UOT #274

Merged
merged 8 commits into from
Oct 25, 2021
Merged

Conversation

haoran010
Copy link
Contributor

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and context / Related issue

add the regularization path for l2 UOT

How has this been tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document.
  • All tests passed, and additional code has been covered with new tests.

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #274 (6627024) into master (d50d814) will increase coverage by 0.13%.
The diff coverage is 95.62%.

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
+ Coverage   92.66%   92.79%   +0.13%     
==========================================
  Files          19       20       +1     
  Lines        3761     3944     +183     
==========================================
+ Hits         3485     3660     +175     
- Misses        276      284       +8     

@rflamary
Copy link
Collaborator

rflamary commented Sep 6, 2021

Hello @haoran010,

This is a fine PR thank you for proposing it.

you need to respect pep8 for this easy tools like autopep8 will do teh job automatically for you.

@rflamary
Copy link
Collaborator

rflamary commented Sep 6, 2021

Also please move your example file in the unbalanced folder, the regpath is solving unbalanecd so it suld be here insteda of its own subfolder.

@haoran010
Copy link
Contributor Author

pep8 should be ok now

@rflamary rflamary merged commit 7af8c21 into PythonOT:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants