Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Cleanup minimal build and add separate build for pep8 #210

Merged
merged 10 commits into from
Oct 22, 2020

Conversation

rflamary
Copy link
Collaborator

@rflamary rflamary commented Sep 11, 2020

Types of changes

  • cleanupothe build_minimal that had numpy, scipy cython version forced and was failing
  • add a separate pep8 build so taht all teh otehr test can still run in pep8 fails
  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and context / Related issue

The build was failing in all the PR becausqe of that.

The pep8 was a pain when a new commit was necessary in order to get tye output of the tests when pep8 failure

How has this been tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document.
  • All tests passed, and additional code has been covered with new tests.

@rflamary
Copy link
Collaborator Author

I'm a bit puzzled by this. The minimal build (during the tests) fails most of the time with just a coment that it was too long.

If you rerun it several times sometimes it passes. This an an awfull bug that i cannot reproduce on my machine.

It usually gets stuck after
test/test_ot.py::test_emd_empty PASSED [ 55%]

so during test_emd2_multi

this one has been a pain and i'm thinking about rewriting the multi-proc implementation but it will take some time.

@rflamary rflamary changed the title [WIP] Cleanup minimal build and add separate build for pep8 [MRG] Cleanup minimal build and add separate build for pep8 Oct 22, 2020
@rflamary rflamary merged commit 7adc1b1 into master Oct 22, 2020
@rflamary rflamary deleted the debug_minimal_build branch October 22, 2020 08:16
@rflamary rflamary restored the debug_minimal_build branch November 10, 2020 14:41
@rflamary rflamary deleted the debug_minimal_build branch April 22, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant