[MRG] Fix requirements #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's failing from |
djsutherland
force-pushed
the
setup-requires
branch
from
f4d2623 to
4bb1178
Compare
|
(Rebased onto #176 to avoid the flake8 error.) |
agramfort
approved these changes
May 13, 2020
|
I agree this is a much better requirement definition. we were clearly over eager before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in conda-forge/pot-feedstock#9 (comment) – the
setup_requiresandinstall_requiresseem to be slightly wrong as they are now (and there's no such key asrequiresas far as I can tell).