Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PEP 625 (naming of sdists and projects) #23

Closed
philthompson10 opened this issue May 24, 2024 · 3 comments
Closed

Implement PEP 625 (naming of sdists and projects) #23

philthompson10 opened this issue May 24, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@philthompson10
Copy link
Contributor

PEP 625 and the current wheel spec. specify that project names and sdists should use lower case names. Implementing this will change the names of sdists and wheels which may cause problems for external tooling and so should probably be done as part of a feature release.

setuptools v69.3.0 implemented this support which impacts the names of the generated sip module sdists, but does not impact the names of the corresponding wheels (which is determined by the project name set by sip-module).

The project name in the generated sip modules' pyproject.toml files should be lower case and lower case should be used in the name of any generated sdist and wheel files.

@philthompson10 philthompson10 added the bug Something isn't working label May 24, 2024
@philthompson10 philthompson10 self-assigned this Oct 13, 2024
@philthompson10
Copy link
Contributor Author

Ultimately the specification of the format of a distribution name (and therefore sdist and wheel file names) is in the Escaping and Unicode section of the binary distribution section of the Python Packaging User Guide. Although it specifies the use of lower case characters it also states that tools consuming wheels must also be prepared to accept upper case characters.

We therefore choose the leave the current implementation as it is to avoid potential compatibility problems for existing projects. It is up to project authors to implement distribution names as they see fit.

@philthompson10 philthompson10 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 14, 2024
@philthompson10
Copy link
Contributor Author

PyPI is now sending emails warning that in future sdists must conform to PEP 625.

@philthompson10 philthompson10 reopened this Dec 9, 2024
philthompson10 added a commit to philthompson10/sip that referenced this issue Dec 9, 2024
The sdists created by `sip-sdist` are now compatible with PEP 625 in that
they have lower case names.  This ensures that they will still be able to
be uploaded to PyPI.

Resolves Python-SIP#23
@philthompson10
Copy link
Contributor Author

sdists now have lower case file names but the project names have been left untouched. Hopefully this is enough to satisfy PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant