Skip to content

Conversation

@nielstron
Copy link
Contributor

Attempts to resolve #381 as proposed by @nullhashpixel

@codecov
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.30%. Comparing base (3ca745a) to head (4a6b697).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pycardano/backend/ogmios_v6.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
+ Coverage   85.23%   85.30%   +0.07%     
==========================================
  Files          32       32              
  Lines        4213     4213              
  Branches     1060     1060              
==========================================
+ Hits         3591     3594       +3     
+ Misses        435      434       -1     
+ Partials      187      185       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cffls
Copy link
Collaborator

cffls commented Oct 11, 2024

Seems like the integration test has failed with errors like this:

FAILED test/test_plutus.py::TestPlutus::test_plutus_v2_inline_script_inline_datum - AttributeError: 'dict' object has no attribute 'language'

@nielstron nielstron force-pushed the fix/ogmiosv6_plutus branch from 6cf5352 to 4a6b697 Compare October 12, 2024 10:17
@nielstron
Copy link
Contributor Author

It seems that the script object is a dict and not (like the typing suggests) a Script object @wrmarchetto

@cffls cffls merged commit 3034cd9 into main Oct 12, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spending UTxOs containing a plutus V3 script fails with Ogmios backend

3 participants