don't use MAX on an UUID field #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long time ago,
ProjectState.idwas an integer, project listing usedMAX(id)and all was good.But since it was global instead of per-project, we didn't want to expose it externally as a sequence number / index of the current state. So, we switched the field to UUID and introduced another,
step_index, which was an integer.No-one bothered to tell poor ol'
get_all_projects()about it, but SQLite happily obliged, calculating maximum value of an unorderable random field (Like the White Queen, SQLite can execute six impossible queries before breakfast).So it was that a brave adventurer ventured forth to the land of PostgreSQL, which immediately complained, as it often will. The omission was detected and promptly fixed, lest no unwary souls get caught in the trap.