use k3s_install_dir instead of hardcoded /usr/local/bin path to install k3s-killall.sh and k3s-uninstall.sh #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteyeux
changed the title
…ll k3s-killall.sh and k3s-uninstall.sh
|
I am not sure what is wrong with the CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use k3s_install_dir instead of hardcoded /usr/local/bin path to install k3s-killall.sh and k3s-uninstall.sh
Fixes #234
Issue type
Test instructions
Change
k3s_install_dirto something else, verify that k3s-killall.sh and k3s-uninstall.sh are copied to the said directory.Additional Information
If the directory does not exist, install will fail. Do you think I should create the directory first ?