Fix(tests): Resolve Ansible Lint warnings and fix Molecule tests on GitHub Actions

tasks/ensure_cluster.yml

@@ -87,20 +87,22 @@
   become: "{{ k3s_become }}"
 
 - name: Ensure secondary controllers are started
-  include_tasks: ensure_control_plane_started_{{ ansible_service_mgr }}.yml
+  ansible.builtin.include_tasks: ensure_control_plane_started_{{ ansible_service_mgr }}.yml
   when:
     - k3s_control_node
     - not k3s_primary_control_node
 
-- import_tasks: post_checks_control_plane.yml
+- name: Ensure control plane post checks
+  ansible.builtin.import_tasks: post_checks_control_plane.yml
   when:
     - not k3s_skip_validation
     - not k3s_skip_post_checks
 
 - name: Flush Handlers
   ansible.builtin.meta: flush_handlers
 
-- import_tasks: post_checks_nodes.yml
+- name: Ensure node post checks
+  ansible.builtin.import_tasks: post_checks_nodes.yml
   when:
     - not k3s_skip_validation
     - not k3s_skip_post_checks

tasks/ensure_installed.yml

@@ -1,11 +1,13 @@
 ---
 
-- include_tasks: ensure_directories.yml
+- name: Ensure directories
+  ansible.builtin.include_tasks: ensure_directories.yml
   loop: "{{ k3s_ensure_directories_exist }}"
   loop_control:
     loop_var: directory
 
-- include_tasks: ensure_installed_node.yml
+- name: Ensure installed node
+  ansible.builtin.include_tasks: ensure_installed_node.yml
   when:
     - ((k3s_control_node and k3s_controller_list | length == 1)
         or (k3s_primary_control_node and k3s_controller_list | length > 1))
@@ -14,15 +16,17 @@
 - name: Flush Handlers
   ansible.builtin.meta: flush_handlers
 
-- include_tasks: ensure_installed_node.yml
+- name: Ensure installed node
+  ansible.builtin.include_tasks: ensure_installed_node.yml
   when: k3s_build_cluster
 
 - name: Determine if the systems are already clustered
   ansible.builtin.stat:
     path: "{{ k3s_token_location }}"
   register: k3s_token_cluster_check
 
-- include_tasks: ensure_control_plane_started_{{ ansible_service_mgr }}.yml
+- name: Ensure control plane started
+  ansible.builtin.include_tasks: ensure_control_plane_started_{{ ansible_service_mgr }}.yml
   when: (k3s_control_node and k3s_controller_list | length == 1)
         or (k3s_primary_control_node and k3s_controller_list | length > 1)
         or k3s_token_cluster_check.stat.exists

tasks/main.yml

@@ -1,5 +1,7 @@
 ---
 
-- import_tasks: pre_checks.yml
+- name: Begin pre-checks
+  ansible.builtin.import_tasks: pre_checks.yml
 
-- include_tasks: state_{{ (k3s_state | lower) | default('installed') }}.yml
+- name: "Ensure state {{ (k3s_state | lower) | default('installed') }}"
+  ansible.builtin.include_tasks: state_{{ (k3s_state | lower) | default('installed') }}.yml

tasks/pre_checks.yml

@@ -50,7 +50,7 @@
     - not k3s_skip_validation
     - not k3s_skip_env_checks
 
-- name: Determing if {{ ansible_service_mgr }} is actually openrc
+- name: Determining if {{ ansible_service_mgr }} is actually openrc
   ansible.builtin.stat:
     path: /sbin/openrc-run
   register: k3s_check_openrc_run
@@ -71,22 +71,25 @@
     - not k3s_skip_validation
     - not k3s_skip_env_checks
 
-- include_tasks: pre_checks_version.yml
+- name: Ensure version pre-checks
+  ansible.builtin.include_tasks: pre_checks_version.yml
   when:
     - (k3s_release_version is not defined
         or not k3s_release_version
         or k3s_release_version is not regex('\\+k3s[1-9]$'))
     - not k3s_airgap
 
-- include_tasks: pre_checks_cgroups.yml
+- name: Ensure cgroups pre-checks
+  ansible.builtin.include_tasks: pre_checks_cgroups.yml
   loop: "{{ k3s_cgroup_subsys }}"
   loop_control:
     loop_var: cgroup
   when:
     - not k3s_skip_validation
     - not k3s_skip_env_checks
 
-- include_tasks: pre_checks_packages.yml
+- name: Ensure packages pre-checks
+  ansible.builtin.include_tasks: pre_checks_packages.yml
   loop: "{{ k3s_check_packages[k3s_os_distribution_version] }}"
   loop_control:
     loop_var: package
@@ -95,28 +98,34 @@
     - not k3s_skip_env_checks
     - k3s_check_packages[k3s_os_distribution_version] is defined
 
-- include_tasks: pre_checks_issue_data.yml
+- name: Ensure issue data pre-checks
+  ansible.builtin.include_tasks: pre_checks_issue_data.yml
   when:
     - pyratlabs_issue_controller_dump is defined
     - pyratlabs_issue_controller_dump
 
-- import_tasks: pre_checks_variables.yml
+- name: Ensure variables pre-checks
+  ansible.builtin.import_tasks: pre_checks_variables.yml
   when:
     - not k3s_skip_validation
 
-- import_tasks: pre_checks_experimental_variables.yml
+- name: Ensure experimental variables pre-checks
+  ansible.builtin.import_tasks: pre_checks_experimental_variables.yml
   when:
     - not k3s_skip_validation
 
-- import_tasks: pre_checks_unsupported_rootless.yml
+- name: Ensure unsupported rootless pre-checks
+  ansible.builtin.import_tasks: pre_checks_unsupported_rootless.yml
   when:
     - k3s_runtime_config.rootless is defined
     - k3s_runtime_config.rootless
     - not k3s_skip_validation
 
-- import_tasks: ensure_pre_configuration.yml
+- name: Ensure preconfiguration
+  ansible.builtin.import_tasks: ensure_pre_configuration.yml
 
-- import_tasks: pre_checks_control_node_count.yml
+- name: Ensure control node count pre-checks
+  ansible.builtin.import_tasks: pre_checks_control_node_count.yml
   when:
     - k3s_build_cluster is defined
     - k3s_build_cluster

tasks/state_downloaded.yml

@@ -1,12 +1,15 @@
 ---
 
-- import_tasks: pre_checks_version.yml
+- name: Ensure version pre-checks
+  ansible.builtin.import_tasks: pre_checks_version.yml
   when:
     - k3s_release_version is not defined or not k3s_release_version
     - not k3s_airgap
 
-- import_tasks: ensure_downloads.yml
+- name: Ensure downloads
+  ansible.builtin.import_tasks: ensure_downloads.yml
   when: not k3s_airgap
 
-- import_tasks: ensure_uploads.yml
+- name: Ensure uploads
+  ansible.builtin.import_tasks: ensure_uploads.yml
   when: k3s_airgap

tasks/state_installed.yml

@@ -21,12 +21,14 @@
 
 - import_tasks: ensure_installed.yml
 
-- include_tasks: ensure_containerd_registries.yml
+- name: Ensure containerd registries
+  ansible.builtin.include_tasks: ensure_containerd_registries.yml
   when:
     - k3s_registries is defined
     - ('rootless' not in k3s_runtime_config or not k3s_runtime_config.rootless)
 
-- include_tasks: pre_checks_cluster.yml
+- name: Ensure cluster pre-checks
+  ansible.builtin.include_tasks: pre_checks_cluster.yml
   when:
     - k3s_control_delegate is defined
     - k3s_control_delegate == inventory_hostname