-
Notifications
You must be signed in to change notification settings - Fork 562
Remove sorting from tabular_writer
#3804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3804 +/- ##
==========================================
+ Coverage 89.43% 89.45% +0.01%
==========================================
Files 905 905
Lines 105444 105467 +23
==========================================
+ Hits 94302 94342 +40
+ Misses 11142 11125 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blnicho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a few minor typos which I will fix. Otherwise this looks good!
Fixes # .
Supersedes #3578.
Summary/Motivation:
This removes all sorting from the
tabular_writer, and prints out the data in the order in which the data iterator provides it. Control for sorting intpprint()is now exposed through thepprint()API. This makes thetabular_writersimpler / more generic and more usable in other contexts.This is currently backwards compatible with the existing
pprint()infrastructure and will produce the same output. A subsequent PR will rework thepprint()design so that components are output in "ordered" (and not "sorted") order, as well as other changes that might break the output.Changes proposed in this PR:
pprint()private API so that sorting can be controlled by an optional argument topprint()Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: